Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: deduce AutoID from field info #655

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

congqixia
Copy link
Contributor

Resolves: #654

@sre-ci-robot sre-ci-robot requested review from sunby and yah01 January 17, 2024 04:22
@sre-ci-robot
Copy link

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: congqixia

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@sre-ci-robot sre-ci-robot added approved review approved size/XS Denotes a PR that changes 0-9 lines. labels Jan 17, 2024
Copy link

codecov bot commented Jan 17, 2024

Codecov Report

Attention: 2 lines in your changes are missing coverage. Please review.

Comparison is base (5c2414c) 73.26% compared to head (b471b95) 73.22%.
Report is 3 commits behind head on master.

❗ Current head b471b95 differs from pull request most recent head 890de2b. Consider uploading reports for the commit 890de2b to get more accurate results

Additional details and impacted files

Impacted file tree graph

@@            Coverage Diff             @@
##           master     #655      +/-   ##
==========================================
- Coverage   73.26%   73.22%   -0.05%     
==========================================
  Files          46       46              
  Lines        4290     4291       +1     
==========================================
- Hits         3143     3142       -1     
- Misses       1034     1035       +1     
- Partials      113      114       +1     
Files Coverage Δ
entity/schema.go 90.21% <0.00%> (-1.04%) ⬇️

sre-ci-robot pushed a commit that referenced this pull request Jan 17, 2024
cherry pick from master
pr: #655 
Resolves: #654

---------

Signed-off-by: Congqi Xia <[email protected]>
@congqixia congqixia force-pushed the fix_collection_autoid branch from b471b95 to 890de2b Compare January 30, 2024 04:53
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved review approved size/XS Denotes a PR that changes 0-9 lines.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[Bug]: Collection schema from DescribeCollection uses deprecated AutoID field
2 participants